Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal to display ingest errors #577

Closed
jameskerr opened this issue Apr 8, 2020 · 1 comment · Fixed by #672
Closed

Modal to display ingest errors #577

jameskerr opened this issue Apr 8, 2020 · 1 comment · Fixed by #672
Assignees

Comments

@jameskerr
Copy link
Member

When the user clicks on the errors counter, we'll display a modal with a scrolling list of all the errors.

@philrz
Copy link
Contributor

philrz commented Apr 25, 2020

Verified in Brim commit 1fae48f.

In the attached video, I drag in a log file that I know is going to generate a warning (a single JSON line {"foo": "bar"}). Brim now shows a message "Ingest failed with warnings" and a warning icon with a count. When clicked, it pops up a modal with the error detail, which in this case is the accurate message /Users/phil/Desktop/ingest/foo.ndjson: line 1: missing path field.

Verify.zip

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants