Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require Community ID on all pcap-eligible conn records #2830

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Jul 29, 2023

Fixes #2827, which has all the background.

The attached video shows the fix having the desired effect: Now when I have a conn log that lacks a community_id field that meets all the other requirements, the Packets button still lights up.

Verify.mp4

@philrz philrz requested a review from jameskerr July 29, 2023 22:40
@philrz philrz self-assigned this Jul 29, 2023
@philrz philrz merged commit d57629a into main Jul 29, 2023
@philrz philrz deleted the philrz/issue2827-retry branch July 29, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community ID is a prerequisite to activating the Packets button
2 participants