Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese (Portugal) Translations #105

Closed
32 tasks
brminnick opened this issue Jun 15, 2020 · 7 comments · Fixed by #129 or #131
Closed
32 tasks

Add Portuguese (Portugal) Translations #105

brminnick opened this issue Jun 15, 2020 · 7 comments · Fixed by #129 or #131
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@brminnick
Copy link
Owner

brminnick commented Jun 15, 2020

GitTrends provides i18n using RESX.

More information on using RESX with Xamarin.Forms can be found here:
https://docs.microsoft.com/xamarin/xamarin-forms/app-fundamentals/localization/text

All of the .resx files can be found in the GitTrends.Mobile.Common.Constants folder:
https://github.com/brminnick/GitTrends/tree/master/GitTrends.Mobile.Common/Constants

ToDo

  • Implement AppStoreRatingRequestConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> AppStoreRatingRequestConstants.resx </DependentUpon> (Example)
  • Implement DemoUserConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> DemoUserConstants.resx </DependentUpon> (Example)
  • Implement EmptyDataViewConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> EmptyDataViewConstants.resx </DependentUpon> (Example)
  • Implement EmptyDataViewConstantsInternal.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> EmptyDataViewConstantsInternal.resx </DependentUpon> (Example)
  • Implement GitHubLoginButtonConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> GitHubLoginButtonConstants.resx </DependentUpon> (Example)
  • Implement NotificationConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> NotificationConstants.resx </DependentUpon> (Example)
  • Implement OnboardingConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> OnboardingConstants.resx </DependentUpon> (Example)
  • Implement PageTitles.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> PageTitles.resx </DependentUpon> (Example)
  • Implement ReferringSitesPageConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> ReferringSitesPageConstants.resx </DependentUpon> (Example)
  • Implement RepositoryPageConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> RepositoryPageConstants.resx </DependentUpon> (Example)
  • Implement ReviewServiceConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> ReviewServiceConstants.resx </DependentUpon> (Example)
  • Implement SettingsPageConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> SettingsPageConstants.resx </DependentUpon> (Example)
  • Implement SortingConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> SortingConstants.resx </DependentUpon> (Example)
  • Implement SplashScreenPageConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> SplashScreenPageConstants.resx </DependentUpon> (Example)
  • Implement TrendsChartTitleConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> TrendsChartTitleConstants.resx </DependentUpon> (Example)
  • Implement WelcomePageConstants.pt-PT.resx
    • In GitTrends.Mobile.Common.csproj, use <DependentUpon> WelcomePageConstants.resx </DependentUpon> (Example)
@brminnick brminnick added enhancement New feature or request help wanted Extra attention is needed labels Jun 15, 2020
@brminnick brminnick added this to the v1.2.0 milestone Jun 15, 2020
@vitorsaldiva
Copy link

Do you need pt-br or pt-pt translation? There is nuances between these languages...

@jwoeste
Copy link

jwoeste commented Jun 18, 2020 via email

@brminnick
Copy link
Owner Author

brminnick commented Jun 18, 2020

@vitorsaldiva Do you recommend that we do both? I could open another feature request for pt-BR and edit this one for pt-PT.

@brminnick
Copy link
Owner Author

@jwoeste That’d be awesome!!

Could you open another issue for each of the other languages? You can copy/paste this issue and just tweak the language.

@brminnick brminnick changed the title Add Portuguese Translations Add Portuguese (Portugal) Translations Jun 19, 2020
@brminnick
Copy link
Owner Author

@vitorsaldiva I've changed this Issue to focus on pt-PT and opened #119 to focus on pt-BR

Let me know if you have the time to do the translations and I'll assign one (or both) to you! 🤗

@brminnick
Copy link
Owner Author

@jwoeste I went ahead and opened these Feature Requests

If you're able to work on them, leave a comment on each issue and then I'll be able to assign them to you! 🙌

@jwoeste
Copy link

jwoeste commented Jun 19, 2020 via email

@brminnick brminnick linked a pull request Jun 23, 2020 that will close this issue
@brminnick brminnick removed a link to a pull request Jun 23, 2020
This was linked to pull requests Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants