-
Notifications
You must be signed in to change notification settings - Fork 31
Fix workflow #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix workflow #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the npm package setup in the GitHub workflow by consolidating Verdaccio registry configuration and user authentication into dedicated steps, replacing the previous inline approach in the staging package setup.
- Extracted Verdaccio setup and authentication into separate workflow steps
- Added proper health checking for Verdaccio startup with retry logic
- Removed redundant package installation and authentication commands from the staging step
Comments suppressed due to low confidence (1)
.github/workflows/reviewing_changes.yml:67
- [nitpick] The variable name 'i' is ambiguous in this context. Consider renaming it to 'attempt' or 'retry_count' to better reflect its purpose as a retry counter.
for i in {1..30}; do
npx verdaccio@5.32.2 & | ||
for i in {1..30}; do | ||
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi | ||
echo "Waiting for Verdaccio to be ready..."; sleep 2; | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running Verdaccio in the background without capturing its process ID makes it difficult to manage or terminate if needed. Consider storing the PID or using a more robust process management approach.
npx verdaccio@5.32.2 & | |
for i in {1..30}; do | |
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi | |
echo "Waiting for Verdaccio to be ready..."; sleep 2; | |
done | |
npx verdaccio@5.32.2 & echo $! > verdaccio.pid | |
for i in {1..30}; do | |
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi | |
echo "Waiting for Verdaccio to be ready..."; sleep 2; | |
done | |
echo "Verdaccio started with PID $(cat verdaccio.pid)" |
Copilot uses AI. Check for mistakes.
No description provided.