Skip to content

Fix workflow #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix workflow #69

wants to merge 12 commits into from

Conversation

amaanbs
Copy link
Collaborator

@amaanbs amaanbs commented Jul 17, 2025

No description provided.

@amaanbs amaanbs requested a review from a team as a code owner July 17, 2025 21:16
@xxshubhamxx xxshubhamxx requested a review from Copilot July 18, 2025 18:32
Copilot

This comment was marked as outdated.

@xxshubhamxx xxshubhamxx requested a review from Copilot July 18, 2025 18:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the npm package setup in the GitHub workflow by consolidating Verdaccio registry configuration and user authentication into dedicated steps, replacing the previous inline approach in the staging package setup.

  • Extracted Verdaccio setup and authentication into separate workflow steps
  • Added proper health checking for Verdaccio startup with retry logic
  • Removed redundant package installation and authentication commands from the staging step
Comments suppressed due to low confidence (1)

.github/workflows/reviewing_changes.yml:67

  • [nitpick] The variable name 'i' is ambiguous in this context. Consider renaming it to 'attempt' or 'retry_count' to better reflect its purpose as a retry counter.
          for i in {1..30}; do

Comment on lines +66 to +70
npx verdaccio@5.32.2 &
for i in {1..30}; do
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi
echo "Waiting for Verdaccio to be ready..."; sleep 2;
done
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running Verdaccio in the background without capturing its process ID makes it difficult to manage or terminate if needed. Consider storing the PID or using a more robust process management approach.

Suggested change
npx verdaccio@5.32.2 &
for i in {1..30}; do
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi
echo "Waiting for Verdaccio to be ready..."; sleep 2;
done
npx verdaccio@5.32.2 & echo $! > verdaccio.pid
for i in {1..30}; do
if curl -sf http://localhost:4873/-/ping > /dev/null; then break; fi
echo "Waiting for Verdaccio to be ready..."; sleep 2;
done
echo "Verdaccio started with PID $(cat verdaccio.pid)"

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants