Skip to content

Commit

Permalink
Remove bad kmem_free() oversight from previous zfsdev_state_list patch
Browse files Browse the repository at this point in the history
I forgot to remove the corresponding kmem_free() from zfs_kmod_fini() in
9a14ce4. Clang's static analyzer did
not complain, but the Coverity scan that was run after the patch was
merged did.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reported-by: Coverity (CID-1535275)
Closes #14556
  • Loading branch information
ryao authored Mar 1, 2023
1 parent dd108f5 commit 9fd5fed
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion module/zfs/zfs_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -7862,7 +7862,6 @@ zfs_kmod_fini(void)
zfs_onexit_destroy(zs->zs_onexit);
if (zs->zs_zevent)
zfs_zevent_destroy(zs->zs_zevent);
kmem_free(zs, sizeof (zfsdev_state_t));
}

zfs_ereport_taskq_fini(); /* run before zfs_fini() on Linux */
Expand Down

0 comments on commit 9fd5fed

Please sign in to comment.