Bug: When SOPS decryption fails, the error message should tell the user what the issue is

[samip5]

Version: 3.0.4, Darwin arm64

2024/07/29 00:40:36 DEBUG start loading and validating config file
2024/07/29 00:40:36 DEBUG reading talconfig.yaml
2024/07/29 00:40:36 DEBUG substituting config file with environment variable
2024/07/29 00:40:36 DEBUG overriding global controlplane node config for m1
2024/07/29 00:40:36 DEBUG overriding global worker node config for w-amd-1
2024/07/29 00:40:36 DEBUG overriding global worker node config for w-amd-2
2024/07/29 00:40:36 DEBUG overriding global worker node config for w-amd-3
2024/07/29 00:40:36 DEBUG overriding global worker node config for w7
2024/07/29 00:40:36 DEBUG start validating talconfig file
2024/07/29 00:40:36 DEBUG validating config file for node m1
2024/07/29 00:40:36 DEBUG validating schematic with official Talos schematic for node m1
2024/07/29 00:40:36 DEBUG validating config file for node w-amd-1
2024/07/29 00:40:36 DEBUG validating schematic with official Talos schematic for node w-amd-1
2024/07/29 00:40:36 DEBUG validating config file for node w-amd-2
2024/07/29 00:40:36 DEBUG validating schematic with official Talos schematic for node w-amd-2
2024/07/29 00:40:36 DEBUG validating config file for node w-amd-3
2024/07/29 00:40:36 DEBUG validating schematic with official Talos schematic for node w-amd-3
2024/07/29 00:40:36 DEBUG validating config file for node w7
2024/07/29 00:40:36 DEBUG secret file is set to talsecret.sops.yaml
2024/07/29 00:40:36 DEBUG start generating config file
2024/07/29 00:40:36 DEBUG using secret file talsecret.sops.yaml
2024/07/29 00:40:36 DEBUG talsecret.sops.yaml is SOPS encrypted, decrypting
2024/07/29 00:40:36 failed to generate talos config: Error getting data key: 0 successful groups required, got 0

[budimanjojo]

Thank you for reporting!

The error message is reported from SOPS high level api:

talhelper/pkg/decrypt/decrypt.go

Line 41 in 060aeca

decrypted, err := decrypt.Data(data, "yaml")

And the error message is indeed not really useful without --debug flag. I think the best I can do is to clarify that the error came from SOPS like so: failed to generate talos config: SOPS decryption failed: Error getting .... Is this a reasonable fix?

[samip5]

That would help yes.

[budimanjojo]

Should do exactly that when I release a new version, thank you for reporting!

[outbackdingo]

Im seeing it also in a VM with debian, how do we get around this

talhelper genconfig
2024/10/28 05:49:49 failed to generate talos config: SOPS decryption failed: Error getting data key: 0 successful groups required, got 0

[samip5]

Im seeing it also in a VM with debian, how do we get around this

talhelper genconfig 2024/10/28 05:49:49 failed to generate talos config: SOPS decryption failed: Error getting data key: 0 successful groups required, got 0

By making sure your sops works first before trying tailhelper.