core: use deepcopy not gob encoding - closes ory#191

handler/oauth2/strategy_jwt_session.go

@@ -1,12 +1,11 @@
 package oauth2
 
 import (
-	"bytes"
-	"encoding/gob"
 	"time"
 
 	"github.com/ory/fosite"
 	"github.com/ory/fosite/token/jwt"
+	"github.com/mohae/deepcopy"
 )
 
 type JWTSessionContainer interface {
@@ -80,11 +79,5 @@ func (s *JWTSession) Clone() fosite.Session {
 		return nil
 	}
 
-	var clone JWTSession
-	var mod bytes.Buffer
-	enc := gob.NewEncoder(&mod)
-	dec := gob.NewDecoder(&mod)
-	_ = enc.Encode(s)
-	_ = dec.Decode(&clone)
-	return &clone
+	return deepcopy.Copy(s).(fosite.Session)
 }

handler/openid/strategy_jwt.go

@@ -1,15 +1,13 @@
 package openid
 
 import (
-	"encoding/gob"
 	"time"
-
-	"bytes"
 	"context"
 
 	"github.com/ory/fosite"
 	"github.com/ory/fosite/token/jwt"
 	"github.com/pkg/errors"
+	"github.com/mohae/deepcopy"
 )
 
 const defaultExpiryTime = time.Hour
@@ -42,13 +40,7 @@ func (s *DefaultSession) Clone() fosite.Session {
 		return nil
 	}
 
-	var clone DefaultSession
-	var mod bytes.Buffer
-	enc := gob.NewEncoder(&mod)
-	dec := gob.NewDecoder(&mod)
-	_ = enc.Encode(s)
-	_ = dec.Decode(&clone)
-	return &clone
+	return deepcopy.Copy(s).(fosite.Session)
 }
 
 func (s *DefaultSession) SetExpiresAt(key fosite.TokenType, exp time.Time) {

session.go

@@ -1,9 +1,8 @@
 package fosite
 
 import (
-	"bytes"
-	"encoding/gob"
 	"time"
+	"github.com/mohae/deepcopy"
 )
 
 // Session is an interface that is used to store session data between OAuth2 requests. It can be used to look up
@@ -74,11 +73,5 @@ func (s *DefaultSession) Clone() Session {
 		return nil
 	}
 
-	var clone DefaultSession
-	var mod bytes.Buffer
-	enc := gob.NewEncoder(&mod)
-	dec := gob.NewDecoder(&mod)
-	_ = enc.Encode(s)
-	_ = dec.Decode(&clone)
-	return &clone
+	return deepcopy.Copy(s).(Session)
 }