-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): refactored identity show command to use rpc abstraction #3668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @divyank-rs! A couple of things to address:
- You can delete the
unused
methods - Can you add the bats test you mentioned here?
fc4b994
to
3ded6d8
Compare
3ded6d8
to
7ed21e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much @divyank-rs for your contribution! 🎉
…top mapping errors manually
7ed21e2
to
7c363f5
Compare
@divyank-rs thank you for an awesome first contribution 🥳 |
Current Behavior
The current implementation in identity show command is calling std::process::exit, which is something we want to stop using to handle errors properly and give the user a better-formatted output when a command fails.
Proposed Changes
Relating to issue #3562
ockam_command::util::output
forShortIdentityResponse
andLongIdentityResponse
to maintain current code quality and styleallow(unused)
to prevent linting errors.Checks