Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with awscli v2 #37

Closed
pda opened this issue Mar 3, 2020 · 0 comments · Fixed by #40
Closed

Incompatible with awscli v2 #37

pda opened this issue Mar 3, 2020 · 0 comments · Fixed by #40
Assignees

Comments

@pda
Copy link
Contributor

pda commented Mar 3, 2020

This plugin uses aws ecr get-login which was quietly deprected in aws/aws-cli@b83b3a5 which landed in 1.17.10 on 5th Feb (less than a month ago), and completely removed in awscli v2, which is released but not in many distribution channels (package managers etc) yet.

$ aws --version
aws-cli/2.0.2 Python/3.7.3 Linux/5.5.6-arch1-1 botocore/2.0.0dev6

$ aws ecr get-login
usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
...
aws: error: argument operation: Invalid choice, valid choices are:
...

This plugin should instead use aws ec2 get-login-password. However unlike get-login, get-login-password doesn't give us the ECR registry URL (including AWS account ID & region) which should be passed to the docker login command. Deriving it will add some complexity.

@pda pda self-assigned this Mar 3, 2020
pda added a commit to buildkite/elastic-ci-stack-for-aws that referenced this issue Mar 3, 2020
This should be unpinned after ecr-buildkite-plugin adds support for
awscli v2. See:
buildkite-plugins/ecr-buildkite-plugin#37
@pda pda closed this as completed in #40 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant