Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spinnaker ver false #185

Closed
wants to merge 5 commits into from
Closed

spinnaker ver false #185

wants to merge 5 commits into from

Conversation

jiaquan1
Copy link
Contributor

Spinnaker added a version as the suffix in the secret name, confused the container to get the right secrets.

@jiaquan1 jiaquan1 marked this pull request as draft July 19, 2023 19:42
@moskyb
Copy link
Contributor

moskyb commented Jul 26, 2023

g'day @jiaquan1! unfortunately we won't be able to accept this PR, as spinnaker isn't something that all users use.

if you made a PR allowing people to put in arbitrary annotations (similar to #174 and #176), i think that would allow you to work around this?

@jiaquan1 jiaquan1 closed this Jul 26, 2023
@jiaquan1 jiaquan1 reopened this Jul 27, 2023
@jiaquan1 jiaquan1 closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaquan1 @moskyb