From 8ab672bd3e057ef9da9023c838a53fd21289c838 Mon Sep 17 00:00:00 2001 From: James Healy Date: Fri, 17 Mar 2023 23:27:56 +1100 Subject: [PATCH] Fix GitHub release now that we're using OIDC In #133 we updated the relase steps to use OIDC for assuming roles as needed. The release to s3 steps worked as planned, however the release to GitHub step needs some tweaks: 1. fix the SSM parameter store path 2. explictly pass the environment variable into the docker container --- .buildkite/pipeline.release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.buildkite/pipeline.release.yml b/.buildkite/pipeline.release.yml index b9fbd164..a16eb1c3 100644 --- a/.buildkite/pipeline.release.yml +++ b/.buildkite/pipeline.release.yml @@ -22,11 +22,13 @@ steps: role-arn: arn:aws:iam::445615400570:role/pipeline-buildkite-agent-metrics - aws-ssm#v1.0.0: parameters: - GITHUB_RELEASE_ACCESS_TOKEN: /pipelines/buildkite-agent-metrics/GITHUB_RELEASE_ACCESS_TOKEN + GITHUB_RELEASE_ACCESS_TOKEN: /pipelines/buildkite/buildkite-agent-metrics/GITHUB_RELEASE_ACCESS_TOKEN - ecr#v2.0.0: login: true account-ids: "445615400570" - docker#v3.5.0: image: "445615400570.dkr.ecr.us-east-1.amazonaws.com/deploytools:2020.03" propagate-environment: true + environment: + - GITHUB_RELEASE_ACCESS_TOKEN