Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore SSM Session Manager Plugin #1389

Conversation

ellsclytn
Copy link
Contributor

This was removed in the migration to Amazon Linux 3 with the belief that there was no use case for the Session Manager Plugin being present on the agent. It has since been realised that it is quite useful. For example, the agent may be used to start ECS Tasks which perform work in other environments/network configurations (such as Database migrations during deployments).

The install script was first restored (git checkout 2d32dfcc211b268e903a742de87bb27070c53cb7^ -- packer/linux/scripts/install-session-manager-plugin.sh), then modified slightly per AWS documentation for Amazon Linux 3.

@ellsclytn ellsclytn requested review from a team October 24, 2024 21:55
@ellsclytn ellsclytn force-pushed the plt-3319-restore-the-ssm-session-manager-plugin-to-the-elastic-stack branch from 3113bcc to d73dff7 Compare October 24, 2024 21:55
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That argument seems reasonable to me.

packer/linux/scripts/install-session-manager-plugin.sh Outdated Show resolved Hide resolved
@ellsclytn ellsclytn force-pushed the plt-3319-restore-the-ssm-session-manager-plugin-to-the-elastic-stack branch from d73dff7 to 5c423bb Compare October 28, 2024 02:10
This was removed in the migration to Amazon Linux 3 with the belief that
there was no use case for the Session Manager Plugin being present on
the agent[1]. It has since been realised that it is quite useful. For
example, the agent may be used to start ECS Tasks which perform work in
other environments/network configurations (such as Database migrations
during deployments).

1. #1122 (comment)
@ellsclytn ellsclytn force-pushed the plt-3319-restore-the-ssm-session-manager-plugin-to-the-elastic-stack branch from 5c423bb to ecb55e4 Compare October 28, 2024 03:57
@ellsclytn ellsclytn marked this pull request as ready for review October 28, 2024 04:17
@ellsclytn ellsclytn requested a review from a team October 28, 2024 04:17
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍵

@ellsclytn ellsclytn merged commit 421abef into main Oct 28, 2024
1 check passed
@ellsclytn ellsclytn deleted the plt-3319-restore-the-ssm-session-manager-plugin-to-the-elastic-stack branch October 28, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants