Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the path to a project.toml be configured #705

Closed
matthewmcnew opened this issue May 25, 2021 · 4 comments
Closed

Allow the path to a project.toml be configured #705

matthewmcnew opened this issue May 25, 2021 · 4 comments
Assignees
Labels

Comments

@matthewmcnew
Copy link
Collaborator

#690 adds support from project.toml but, will only find a project.toml in the root of supplied source with the name project.toml. While this behavior matches the default behavior of pack, pack also provides the a pack build --descriptor flag which allows users to set the path to a project descriptor. To enable the same behavior in kpack the image and build type should support providing the path to the descriptor in the spec.build.

Adding this functionality, naturally makes sense as an api addition to the new api being introduced in the 0.4.0 release.

@matthewmcnew
Copy link
Collaborator Author

CC' @genevieve. I heard you might have a unique usecase here?

@jromero
Copy link
Contributor

jromero commented Jul 7, 2021

@matthewmcnew is there an RFC (or otherwise high-level view) of changes incorporated in API 0.4.0? Or is it more that it's to signify that "it's ok to break compatibility"?

@matthewmcnew
Copy link
Collaborator Author

@jromero We plan on releasing a new api version alongside the existing v1alpha1 in 0.4. So, this new api version is an opportunity to include any/all breaking changes we would like to incorporate into kpack. At this time we have tagged everything 0.4 that we would like to include.

@tylerphelan tylerphelan self-assigned this Aug 11, 2021
@sambhav
Copy link
Contributor

sambhav commented Oct 5, 2021

Fixed in #800. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants