Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ServiceAccount to ServiceAccountName in v1alpha2 #835

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

matthewmcnew
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #835 (ddc7848) into main (b0cfe2d) will not change coverage.
The diff coverage is 64.70%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files         114      114           
  Lines        5042     5042           
=======================================
  Hits         3465     3465           
  Misses       1207     1207           
  Partials      370      370           
Impacted Files Coverage Δ
pkg/apis/build/v1alpha2/build.go 31.63% <0.00%> (ø)
pkg/apis/build/v1alpha2/build_types.go 100.00% <ø> (ø)
pkg/apis/build/v1alpha2/image_types.go 50.00% <ø> (ø)
pkg/apis/build/v1alpha2/source_resolver_types.go 0.00% <ø> (ø)
pkg/git/resolver.go 0.00% <0.00%> (ø)
pkg/apis/build/v1alpha2/image_builds.go 69.13% <33.33%> (ø)
pkg/apis/build/v1alpha2/build_pod.go 96.53% <50.00%> (ø)
pkg/cnb/cnb_metadata.go 46.29% <50.00%> (ø)
pkg/apis/build/v1alpha2/build_conversion.go 94.02% <100.00%> (ø)
pkg/apis/build/v1alpha2/build_validation.go 89.04% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cfe2d...ddc7848. Read the comment docs.

@tomkennedy513
Copy link
Collaborator

I think the openapi stuff needs to be regenerated

@matthewmcnew matthewmcnew merged commit 949cbfe into main Sep 28, 2021
@matthewmcnew matthewmcnew deleted the serviceaccountName branch September 28, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants