Support registry cache in a private registry #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcnew
changed the title
tomkennedy513
approved these changes
Oct 28, 2021
|
Reported by @jeffellin. |
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 67.39% 67.42% +0.03%
==========================================
Files 115 115
Lines 5226 5231 +5
==========================================
+ Hits 3522 3527 +5
Misses 1341 1341
Partials 363 363
Continue to review full report at Codecov.
|
tylerphelan
approved these changes
Oct 28, 2021
sambhav
approved these changes
Oct 28, 2021
dumez-k
approved these changes
Oct 29, 2021
Without HOME the restore step can not correctly load the docker credentials. This prevents layers from properly being restored from a cache image in a private registry. Without this private cache images would cryptically fail: ``` Restoring metadata for "paketo-buildpacks/ca-certificates:helper" from app image Restoring metadata for "paketo-buildpacks/bellsoft-liberica:helper" from app image Restoring metadata for "paketo-buildpacks/bellsoft-liberica:java-security-properties" from app image Restoring metadata for "paketo-buildpacks/bellsoft-liberica:jre" from app image Restoring metadata for "paketo-buildpacks/bellsoft-liberica:jdk" from cache Restoring metadata for "paketo-buildpacks/maven:application" from cache Restoring metadata for "paketo-buildpacks/maven:cache" from cache Restoring metadata for "paketo-buildpacks/spring-boot:helper" from app image Restoring metadata for "paketo-buildpacks/spring-boot:spring-cloud-bindings" from app image Restoring metadata for "paketo-buildpacks/spring-boot:web-application-type" from app image Layer cache not found ```
matthewmcnew
force-pushed
the
fix-home-dir-anaylze
branch
from
29b70d3
to
dbded51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without HOME the restore step can not correctly load the docker credentials.
This prevents layers from properly being restored from a cache image in a private registry.
Without this change