Allow empty secret refs in service bindings #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcnew
approved these changes
Nov 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 67.39% 68.08% +0.68%
==========================================
Files 116 116
Lines 5233 5164 -69
==========================================
- Hits 3527 3516 -11
+ Misses 1343 1287 -56
+ Partials 363 361 -2
Continue to review full report at Codecov.
|
tylerphelan
approved these changes
Nov 18, 2021
- Prevent nil pointer deref when secret ref is empty on service bindings Co-authored-by: Matthew McNew <mmcnew@vmware.com> Co-authored-by: Kenneth DuMez <kdumez@vmware.com>
tomkennedy513
force-pushed
the
empty-secret-ref
branch
from
326ae25
to
6d90dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Matthew McNew mmcnew@vmware.com
Co-authored-by: Kenneth DuMez kdumez@vmware.com