Add history when adding buildpack or extension layers #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…ssage Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
We need to add to the launch cache when adding layers so that the next build will be faster Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
The digest for a remote image from imgutil should match the digest for a remote image from ggcr unless the user specifically requested modifications like overriding history Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
@natalieparellano does the history from the base image make it into the final image if present? |
jabrown85
approved these changes
May 25, 2023
| const ( | ||
| BuildpackLayerName = "Layer: '%s', Created by buildpack: %s" | ||
| ExtensionLayerName = "Layer: '%s', Created by extension: %s" | ||
| LauncherConfigLayerName = "Buildpacks Launcher Config" |
There was a problem hiding this comment.
Should this be named a little more generic given the layer name?
Suggested change
| LauncherConfigLayerName = "Buildpacks Launcher Config" | |
| LauncherConfigLayerName = "Buildpacks Config" |
There was a problem hiding this comment.
I left as-is for now because https://github.com/buildpacks/rfcs/blob/main/text/0102-history.md has "launcher", but we can change it if anyone has a strong opinion
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
10 tasks
imgutil mutates the image (history) for newer platforms, so the SHA is different Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
diveon an image built using this lifecycle:The first 3 layers are from the base image.