Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extensions not experimental for Platform 0.13 and above #1295

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

prashantrewar
Copy link
Contributor

Summary

Release notes


Related

Resolves #___
#1287

Context

@prashantrewar prashantrewar requested a review from a team as a code owner February 12, 2024 16:50
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @prashantrewar! I think if you make the changes I suggested, the linter will be happy

Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar
Copy link
Contributor Author

prashantrewar commented Feb 13, 2024

Nice work @prashantrewar! I think if you make the changes I suggested, the linter will be happy

Thank you @natalieparellano, I updated the changes but the tests are still failing.

@natalieparellano
Copy link
Member

Ah, so looking at the failure here I think we need to change the test expectation here

@natalieparellano natalieparellano added this to the lifecycle 0.19.0 milestone Feb 14, 2024
@natalieparellano natalieparellano merged commit 92bb4fb into buildpacks:main Feb 15, 2024
10 checks passed
@prashantrewar
Copy link
Contributor Author

Thank you so much @natalieparellano for the guidance and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants