Fix: log level and color level should be configurable via the env #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
force-pushed
the
fix/env-log-color
branch
2 times, most recently
from
54305a4 to
cca3341
Compare
natalieparellano
changed the title
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/env-log-color
branch
from
cca3341 to
1596126
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
+ Coverage 64.60% 64.60% +0.01%
==========================================
Files 101 101
Lines 7007 7008 +1
==========================================
+ Hits 4526 4527 +1
Misses 2069 2069
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. |
natalieparellano
commented
Mar 8, 2024
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jabrown85
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, log level and color level are only configurable via flags (
-log-leveland-no-color).This broke awhile back in an effort to consolidate some logic in the
platformpackage.Release notes
Log level and color level are configurable via the environment (in addition to flags)
Context