Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CNB_TARGET_* env vars on older Platform API #1374

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

natalieparellano
Copy link
Member

Summary

Fixes #1371

Release notes

When populating target data for older platforms, populate OS & architecture as well as distro information


Related

Resolves #1371


Context

Fixes #1371

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner July 9, 2024 15:30
@natalieparellano
Copy link
Member Author

@edmorley could you review this one?

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Copy link
Contributor

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you for working on this!

@natalieparellano natalieparellano merged commit 04f1ad1 into main Jul 9, 2024
8 checks passed
@natalieparellano natalieparellano deleted the fix/cnb-target-vars branch July 9, 2024 17:12
@natalieparellano natalieparellano added this to the lifecycle 0.20.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNB_TARGET_ARCH and CNB_TARGET_OS not set correctly when using Platform API 0.9
3 participants