From b62cfaf5e1f56650de5dacdb4ad7b47575ea41b3 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Sun, 12 Nov 2023 17:15:55 -0700 Subject: [PATCH 1/3] update changelog for v1.7 --- CHANGELOG.rst | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 2cab85602..8345f7020 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,6 +1,45 @@ CHANGELOG ========= +v1.7 (TBD) +---------- + +**Buildspec Changes** + +- Add support for containers via ``container`` property. Initial support includes specifying container runtime, container options, and run command to invoke container. Current support includes `docker`, `podman`, `singularity`. `#1642 `_ +- Update schema for Performance Checks (`assert_ge`, `assert_ne`, `assert_gt`, `assert_ge`, `assert_le`, `assert_lt`, `assert_range`, `contains`, `not_contains`) to support for logical AND/OR. The `mode` key can be defined in each performance check, and list of assertions are defined under `comparisons`. `#1648 `_ + +```yaml + status: + assert_ge: + mode: and + comparisons: + - name: copy + ref: 5000 + - name: scale + ref: 5500 + - name: add + ref: 6000 + - name: triad + ref: 6500 +``` +- Change `mode` property under status check (`status`) to use values `(AND|and|OR|or)`, this is to be consistent with use of `mode` under each performance check such as `assert_ge`. `#1656 `_ + +**Command Line Changes** + +- Remove executors via command line ``buildtest config executors remove``. `#1636 `_ +- Extend support for ``--count`` for other queries in ``buildtest buildspec find`` command. Rewrite regression test for ``buildtest buildspec find`` `#1638 `_ + +**Project Improvements** + +- Buildtest will gracefully terminate running jobs when user hits ``CTRL-C``. For batch jobs, the jobIDs will be cancelled. Add ``trap`` command in generated script to allow users to run script and catch signal interrupt. `#1644 `_ +- Improvement to polling implementation for batch jobs by showing number of jobs by type (PENDING, RUNNING, COMPLETED) in the table. Fix issue where FAILED slurm jobs were not reported. `#1650 `_ +- Add error message of tests in console output of ``buildtest build``. `#1643 `_ +- Change `re.match` -> `re.fullmatch` when hostname with ones specified in configuration file. `#1651 `_ +- Rewrite NERSC CI regression tests, update buildtest configuration and example buildspecs to be run. `#1639 `_ +- Slurm jobs `TIMEOUT` and `OUT_OF_MEMORY` will be reported as completed jobs. `#1653 `_ +- Rewrite documentation for Batch Scheduler, Troubleshooting, Buildtest Features, and improving bash completion script `#1637 `_ + v1.6 (Sep 28th, 2023) ---------------------- From 2fa363f21f78cd5989a3c9469187e800070d6ef5 Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Sun, 12 Nov 2023 17:22:19 -0700 Subject: [PATCH 2/3] make formatting changes --- CHANGELOG.rst | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 8345f7020..e8c6ad99f 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -6,10 +6,26 @@ v1.7 (TBD) **Buildspec Changes** -- Add support for containers via ``container`` property. Initial support includes specifying container runtime, container options, and run command to invoke container. Current support includes `docker`, `podman`, `singularity`. `#1642 `_ -- Update schema for Performance Checks (`assert_ge`, `assert_ne`, `assert_gt`, `assert_ge`, `assert_le`, `assert_lt`, `assert_range`, `contains`, `not_contains`) to support for logical AND/OR. The `mode` key can be defined in each performance check, and list of assertions are defined under `comparisons`. `#1648 `_ +- Add support for containers via ``container`` property. Initial support includes specifying container runtime, container options, and run command to invoke container. Current platform support includes ``docker``, ``podman``, ``singularity``. `#1642 `_. + +.. code-block:: yaml + + buildspecs: + container_commands_ubuntu: + type: script + executor: generic.local.bash + description: run arbitrary linux commands in ubuntu container + container: + platform: "docker" + image: ubuntu:latest + command: bash -c "cat /etc/os-release" + run: | + ls -l /etc/os-release || true + +- Update schema for Performance Checks (``assert_ge``, ``assert_ne``, ``assert_gt``, ``assert_ge``, ``assert_le``, ``assert_lt``, ``assert_range``, ``contains``, ``not_contains``) to support for logical AND/OR. The ``mode`` key can be defined in each performance check, and list of assertions are defined under ``comparisons``. `#1648 `_ + +.. code-block:: yaml -```yaml status: assert_ge: mode: and @@ -22,8 +38,9 @@ v1.7 (TBD) ref: 6000 - name: triad ref: 6500 -``` -- Change `mode` property under status check (`status`) to use values `(AND|and|OR|or)`, this is to be consistent with use of `mode` under each performance check such as `assert_ge`. `#1656 `_ + + +- Change `mode` property under status check (``status``) to use values ``(AND|and|OR|or)``, this is to be consistent with use of ``mode`` under each performance check such as ``assert_ge``. `#1656 `_ **Command Line Changes** @@ -35,10 +52,10 @@ v1.7 (TBD) - Buildtest will gracefully terminate running jobs when user hits ``CTRL-C``. For batch jobs, the jobIDs will be cancelled. Add ``trap`` command in generated script to allow users to run script and catch signal interrupt. `#1644 `_ - Improvement to polling implementation for batch jobs by showing number of jobs by type (PENDING, RUNNING, COMPLETED) in the table. Fix issue where FAILED slurm jobs were not reported. `#1650 `_ - Add error message of tests in console output of ``buildtest build``. `#1643 `_ -- Change `re.match` -> `re.fullmatch` when hostname with ones specified in configuration file. `#1651 `_ +- Change ``re.match`` -> ``re.fullmatch`` when hostname with ones specified in configuration file. `#1651 `_ - Rewrite NERSC CI regression tests, update buildtest configuration and example buildspecs to be run. `#1639 `_ -- Slurm jobs `TIMEOUT` and `OUT_OF_MEMORY` will be reported as completed jobs. `#1653 `_ -- Rewrite documentation for Batch Scheduler, Troubleshooting, Buildtest Features, and improving bash completion script `#1637 `_ +- Slurm jobs ``TIMEOUT`` and ``OUT_OF_MEMORY`` will be reported as completed jobs. `#1653 `_ +- Rewrite documentation for Batch Scheduler, Troubleshooting, Buildtest Features, and improving bash completion script. `#1637 `_ v1.6 (Sep 28th, 2023) ---------------------- From f2fd0693609251d6b54d9070495d31969988da5e Mon Sep 17 00:00:00 2001 From: Shahzeb Siddiqui Date: Sun, 12 Nov 2023 17:59:22 -0700 Subject: [PATCH 3/3] add date for v1.7 release --- CHANGELOG.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index e8c6ad99f..a7f0b8343 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,8 +1,8 @@ CHANGELOG ========= -v1.7 (TBD) ----------- +v1.7 (Nov 12th, 2023) +---------------------- **Buildspec Changes**