Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for bullet_train <=> bullet_train-api #711

Open
jagthedrummer opened this issue Dec 4, 2023 · 1 comment
Open

Fix dependencies for bullet_train <=> bullet_train-api #711

jagthedrummer opened this issue Dec 4, 2023 · 1 comment

Comments

@jagthedrummer
Copy link
Contributor

Currently we assume that every app will use the -api gem, and we extend parts of the user-facing stuff from the API stuff. But the dependency graph points the wrong way.

We don't have bullet_train-api listed as a dependency in bullet_train.gemspec.

And we do have bullet_train as a dependency in bullet_train-api.gemspec.

We should reverse these and have our declared dependencies match the actual dependency graph.

@jagthedrummer
Copy link
Contributor Author

Even better would be if we could actually fulfill dependency graph that we currently state. It would be nice if the api gem were optional so that developers could easily replace it with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant