Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying to heroku is broken after upgrading to yarn 4 #1496

Closed
jagthedrummer opened this issue May 29, 2024 · 4 comments · Fixed by #1498
Closed

Deploying to heroku is broken after upgrading to yarn 4 #1496

jagthedrummer opened this issue May 29, 2024 · 4 comments · Fixed by #1498

Comments

@jagthedrummer
Copy link
Contributor

Pushing to heroku fails with this error:

remote: -----> Installing dependencies        
remote:        Installing node modules (yarn.lock)        
remote:        Unknown Syntax Error: Invalid option name ("--production=false").        
remote:                
remote:        $ yarn install [--json] [--immutable] [--immutable-cache] [--refresh-lockfile] [--check-cache] [--check-resolutions] [--inline-builds] [--mode #0]
@jagthedrummer
Copy link
Contributor Author

Related issues:

heroku/buildpacks-nodejs#246

yarnpkg/berry#4608

@jagthedrummer
Copy link
Contributor Author

A complicating factor here is that Heroku recommends putting the heroku/nodejs buildpack before heroku/ruby but that's causing problems because our build step in package.json assumes that it can use the bundle command (for some reason that I don't fully understand at the moment) which isn't installed yet if we follow Heroku's recommendation.

@deepakmahakale
Copy link

A complicating factor here is that Heroku recommends putting the heroku/nodejs buildpack before heroku/ruby but that's causing problems because our build step in package.json assumes that it can use the bundle command (for some reason that I don't fully understand at the moment) which isn't installed yet if we follow Heroku's recommendation.

I can confirm this works as on 25th Jul 2024

@jagthedrummer
Copy link
Contributor Author

Thanks for the confirmation @deepakmahakale. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants