Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set passive to false when binding mouse wheel event listeners #355

Closed
wants to merge 1 commit into from

Conversation

Bigfellahull
Copy link

Mousewheel event listeners registered on document level targets in Chrome will be treated as passive unless explicitly set to false. Calling preventDefault inside passive listeners is ignored and logs a console error. I've changed the mousewheel add listener calls to now explicitly set passive to false when needed.

This should address issue #337 and #331.

Mousewheel event listeners registered on document level targets in Chrome will be treated as passive unless explicitly set to false. Calling preventDefault inside passive listeners is ignored and logs a console error. I've changed the mousewheel add listener calls to now explicitly set passive to false when needed.
@ariutta
Copy link
Collaborator

ariutta commented Oct 29, 2019

Hi @Bigfellahull, thanks for the pull request! I want to give @bumbu a chance to review this, if he has time, so I'm going to wait before merging.

@bumbu
Copy link
Owner

bumbu commented Nov 12, 2019

Looks good as long as we make sure it doesn't break in other browsers

@BodoMinea
Copy link

This is working as intended, fixed my problems on Chrome.

@ariutta
Copy link
Collaborator

ariutta commented Mar 17, 2021

Thanks for the pull request and sorry for the delay in responding. My job has shifted away from front end, so I unfortunately can't keep up with maintenance. Would you be interested in becoming a maintainer?

#395

zkxs added a commit to zkxs/zkxs.github.com that referenced this pull request Mar 1, 2022
@bumbu
Copy link
Owner

bumbu commented Feb 11, 2024

Should be fixed now in a408e0c
Thanks for the PR!

@bumbu bumbu closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants