GC: wasmparser: recursive type groups support #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
reviewed
Jul 27, 2023
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Thanks! A couple things below before we can merge this.
Additionally, can we have some tests for
- Empty rec groups
- Invalid modules that try to be type recursive across different groups
- Any other edge cases you can think of
Remove unnecessary type annotations.
fitzgen
reviewed
Aug 21, 2023
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Looking good, very close! Just one thing left to address before we can merge this. Thanks for your patience!
fitzgen
approved these changes
Aug 23, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Aug 25, 2023
This commit is a follow-up to bytecodealliance#1134 to require the `gc` feature flag be activated to use the `(rec ...)` construct from the GC wasm proposal. This additionally updates the text parsing and text printing to consider the structure of what's parsed for encoding/printing rather than the size of the types inside. Even a `rec` group of a single type prints a `rec` group or encodes it now instead of silently switching it back to a single-type encoding.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Aug 25, 2023
This commit is a follow-up to bytecodealliance#1134 to require the `gc` feature flag be activated to use the `(rec ...)` construct from the GC wasm proposal. This additionally updates the text parsing and text printing to consider the structure of what's parsed for encoding/printing rather than the size of the types inside. Even a `rec` group of a single type prints a `rec` group or encodes it now instead of silently switching it back to a single-type encoding.
alexcrichton
added a commit
that referenced
this pull request
Aug 25, 2023
This commit is a follow-up to #1134 to require the `gc` feature flag be activated to use the `(rec ...)` construct from the GC wasm proposal. This additionally updates the text parsing and text printing to consider the structure of what's parsed for encoding/printing rather than the size of the types inside. Even a `rec` group of a single type prints a `rec` group or encodes it now instead of silently switching it back to a single-type encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for recursive types as part of the ongoing WebAssembly GC proposal implementation.
Matching rules for subtypes had to be updated to accommodate recursive types.