Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iadd_cout and family not legalized for i8 and i16 #1099

Closed
bjorn3 opened this issue Jul 13, 2019 · 1 comment
Closed

iadd_cout and family not legalized for i8 and i16 #1099

bjorn3 opened this issue Jul 13, 2019 · 1 comment
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 13, 2019

https://github.com/CraneStation/cranelift/blob/2b1cfea1634c58d22b880eb082c748350041c3f0/cranelift-codegen/meta/src/shared/legalize.rs#L465-L515

They are put in the expand group, which doesn't run for i8 and i16.
@alexcrichton alexcrichton transferred this issue from bytecodealliance/cranelift Feb 28, 2020
@alexcrichton alexcrichton added bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator labels Feb 28, 2020
@cfallin
Copy link
Member

cfallin commented May 4, 2022

This is I think subsumed by the more general issue of needing to properly support bool carry flag outputs (#2860), so I will close in favor of that.

@cfallin cfallin closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @cfallin @bjorn3