Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simd i32x4 trunc sat f64x2 for x64 #3114

Conversation

jlb6740
Copy link
Contributor

@jlb6740 jlb6740 commented Jul 26, 2021

No description provided.

@jlb6740 jlb6740 force-pushed the implement_simd_i32x4_trunc_sat_f64x2_for_x64 branch from 28aa2c2 to 4e4d5fc Compare July 26, 2021 17:47
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Jul 26, 2021
@jlb6740 jlb6740 force-pushed the implement_simd_i32x4_trunc_sat_f64x2_for_x64 branch 2 times, most recently from e2e6d81 to e3379ac Compare July 26, 2021 20:23
@jlb6740 jlb6740 requested review from cfallin and abrown July 26, 2021 20:23
@cfallin
Copy link
Member

cfallin commented Jul 26, 2021

@jlb6740 There are a bunch of scratch files that look like they were accidentally added to this PR -- could you amend those out?

@jlb6740 jlb6740 force-pushed the implement_simd_i32x4_trunc_sat_f64x2_for_x64 branch 2 times, most recently from 733a602 to da1154e Compare July 27, 2021 02:47
@jlb6740 jlb6740 force-pushed the implement_simd_i32x4_trunc_sat_f64x2_for_x64 branch from da1154e to 500f530 Compare July 27, 2021 06:11
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cfallin cfallin merged commit 8545ca9 into bytecodealliance:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants