From 92ab0932e78cb5ce1f2264bf7d86997d72a790f0 Mon Sep 17 00:00:00 2001 From: Ben Adair Date: Mon, 5 Nov 2018 16:02:22 -0800 Subject: [PATCH 1/2] Update core.js selection.selectAll doesn't support array syntax --- src/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core.js b/src/core.js index 5884888f6..d114dcfe0 100644 --- a/src/core.js +++ b/src/core.js @@ -903,7 +903,7 @@ ChartInternal.prototype.updateSvgSize = function() { var $$ = this, brush = $$.svg.select(".c3-brush .overlay"); $$.svg.attr('width', $$.currentWidth).attr('height', $$.currentHeight); - $$.svg.selectAll(['#' + $$.clipId, '#' + $$.clipIdForGrid]).select('rect') + $$.svg.selectAll(['#' + $$.clipId + ',#' + $$.clipIdForGrid]).select('rect') .attr('width', $$.width) .attr('height', $$.height); $$.svg.select('#' + $$.clipIdForXAxis).select('rect') From 9276ba096898bf3c122e41c0b1215ffdd151d948 Mon Sep 17 00:00:00 2001 From: Ben Adair Date: Mon, 12 Nov 2018 11:16:58 -0800 Subject: [PATCH 2/2] Update core.js updateSvgSize use of selectAll Forgot to take out the array brackets in the first commit. The array version is fragile in our platform, so using the common comma separated string of selectors instead. --- src/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core.js b/src/core.js index d114dcfe0..a83dda259 100644 --- a/src/core.js +++ b/src/core.js @@ -903,7 +903,7 @@ ChartInternal.prototype.updateSvgSize = function() { var $$ = this, brush = $$.svg.select(".c3-brush .overlay"); $$.svg.attr('width', $$.currentWidth).attr('height', $$.currentHeight); - $$.svg.selectAll(['#' + $$.clipId + ',#' + $$.clipIdForGrid]).select('rect') + $$.svg.selectAll('#' + $$.clipId + ',#' + $$.clipIdForGrid).select('rect') .attr('width', $$.width) .attr('height', $$.height); $$.svg.select('#' + $$.clipIdForXAxis).select('rect')