Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Api Server Timeout Argument Doesn't Override Default Timeout Value #117

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

samuel-esp
Copy link
Collaborator

@samuel-esp samuel-esp commented Nov 20, 2024

Motivation

The newly introduced --api-server-timeout is not applying the user-defined timeout to the Kubeconfig created by Pykube because the monkey patching occurs after the Kubeconfig has been created.

Changes

Refactored the logic, the --api-server-timeout will inject its value thourgh the HTTPObject Constructor instead of monkeypatching PyKube library

Tests done

  • Unit Tests
  • Built a Custom Imaged and Tested

TODO

  • I've assigned myself to this PR

@samuel-esp samuel-esp changed the title Fix: --pi-server-timeout Argument Doesn't Override Default Timeout Value Fix: Api Server Timeout Argument Doesn't Override Default Timeout Value Nov 20, 2024
@samuel-esp samuel-esp self-assigned this Nov 20, 2024
@samuel-esp samuel-esp added bug Something isn't working fix labels Nov 20, 2024
@samuel-esp samuel-esp linked an issue Nov 20, 2024 that may be closed by this pull request
@samuel-esp samuel-esp marked this pull request as ready for review November 20, 2024 18:39
kube_downscaler/scaler.py Show resolved Hide resolved
@samuel-esp samuel-esp requested a review from JTaeuber November 22, 2024 17:07
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
2 participants