Fix: Api Server Timeout Argument Doesn't Override Default Timeout Value #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The newly introduced
--api-server-timeout
is not applying the user-defined timeout to the Kubeconfig created by Pykube because the monkey patching occurs after the Kubeconfig has been created.Changes
Refactored the logic, the
--api-server-timeout
will inject its value thourgh the HTTPObject Constructor instead of monkeypatching PyKube libraryTests done
TODO