Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Test_Scale_Custom_Timeout After Merging #121

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix: Test_Scale_Custom_Timeout After Merging #121

merged 1 commit into from
Nov 29, 2024

Conversation

samuel-esp
Copy link
Collaborator

Motivation

After merging the test_scale_custom_timeout was missing the max_retries_on_conflict argument

Changes

inserting max_retries_on_conflict argument inside the test

Tests done

Unit tests

TODO

  • I've assigned myself to this PR

@samuel-esp samuel-esp marked this pull request as ready for review November 27, 2024 14:45
@samuel-esp samuel-esp changed the title Fix: test_scale_custom_timeout( after merging Fix: Test_Scale_Custom_Timeout After Merging Nov 27, 2024
@samuel-esp samuel-esp self-assigned this Nov 27, 2024
@samuel-esp samuel-esp added the fix label Nov 27, 2024
JTaeuber
JTaeuber approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens to the best of us.

@samuel-esp samuel-esp merged commit 0631d35 into caas-team:main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber approved these changes

@Fovty Fovty Awaiting requested review from Fovty Fovty is a code owner

@jonathan-mayer jonathan-mayer Awaiting requested review from jonathan-mayer jonathan-mayer is a code owner

Assignees

@samuel-esp samuel-esp

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuel-esp @JTaeuber @samuel-esposito-enel