Added extraConfig helm field, so configuration can be better describe… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatschknoedel
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
added 2 commits
April 29, 2024 13:42
… since these namespaces can be regex, which results in wrong escaping with double quotes
eumel8
approved these changes
May 7, 2024
This was referenced May 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d declaratively
Motivation
Declarative description of deployments is something very convenient when you want to know in which state your cluster is.
This pr adds further configuration capability to the helm chart.
Changes
Added a helm field .Values.extraConfig, which is a String that gets added in the configmap under the data closure.
This enables the helm user to set configurations trough environment variables.
Tests done
helm lint
helm template
TODO