Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overriding build flags from environment #104

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

aabelix
Copy link
Contributor

@aabelix aabelix commented Jun 16, 2022

Add environment variable

XCADDY_GOBUILDFLAGS

to override default build arguments from environment (close #102).

To support flags with variable arguments Unix-style quoting is supported.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This'll be really helpful; just a couple of thoughts before merging...

README.md Outdated Show resolved Hide resolved
builder.go Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
Add environment variable

 XCADDY_GO_BUILD_FLAGS

to override default build arguments from environment (caddyserver#102).

To support flags with variable arguments Unix-style quoting is supported.
@aabelix aabelix force-pushed the feature/env-override-build-flags branch from 29ad991 to 79fef6b Compare June 17, 2022 07:20
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mholt mholt merged commit 47f9ded into caddyserver:master Jun 20, 2022
@aabelix aabelix deleted the feature/env-override-build-flags branch June 20, 2022 20:03
@aabelix
Copy link
Contributor Author

aabelix commented Jun 20, 2022

Thanks for the contribution!

You are welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clean modules installed by xcaddy build
2 participants