Handle replacements properly for runDev()

[simnalamburt]

Closes #68

1. Handle all possible replacements properly for runDev(). Replacement targets are not always paths.
2. Parse replacement info from go list -m -json all. It's more robust in this way.

I have tested all possible cases with replacements like below. So hopefully replacements won't cause any issue further at least for the runDev().

replace (
	replacetest1 v1.2.3 => golang.org/x/example v0.0.0-20210811190340-787a929d5a0d
	replacetest2 => golang.org/x/example v0.0.0-20210407023211-09c3a5e06b5d
	replacetest3 v1.2.3 => ./fork1
	replacetest4 => ./fork2
	replacetest5 v1.2.3 => /home/username/fork3
	replacetest6 => /home/username/fork4
)

Use forked version of xcaddy if you want to test this PR:

go install github.com/simnalamburt/xcaddy/cmd/xcaddy@466a1a4b86

References

• https://pkg.go.dev/cmd/go/internal/list#pkg-variables

[mohammed90]

Thank you, @simnalamburt! If you don't mind, since you've stumbled upon an edge case, do you mind adding few tests to further validate the logic? We'd hate to break existing users while fixing a bug.

[simnalamburt]

I’m not familiar with xcaddy internals (this is my first day with xcaddy, and I’ve never used go for last 3 years) so actually I don’t know how to do it. Can you give me some brief guide of how to test this? 2021년 8월 30일 (월) 04:46, Mohammed Al Sahaf ***@***.***>님이 작성:

…

Thank you, @simnalamburt <https://github.com/simnalamburt>! If you don't mind, since you've stumbled upon an edge case, do you mind adding few tests to further validate the logic? We'd hate to break existing users while fixing a bug. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB235NAYJXHDTVGTSOPBNTT7KFCBANCNFSM5DAOIM4Q> .

[mholt]

I think unit tests would go a long way, at least. Might have to split some of the logic into a separate function to do that effectively. Basically checking that the input and outputs are as expected. https://pkg.go.dev/testing is your friend. 👍

[simnalamburt]

Maybe I can separate executing go list -m -json all part and parsing the output part. Then unit testing the parsing part should be easy since it's IO free. Thanks @mholt! :)

[simnalamburt]

I think I’ve done some basic testing :) Please feel free to take a look!

[simnalamburt]

Omg the test was UNIX specific 🤦 hang on

[mohammed90]

Omg the test was UNIX specific 🤦 hang on

Yay for tests 🙂

[mohammed90]

Omg the test was UNIX specific 🤦 hang on

Let me try to make the issue clearer. Note the slashes here:

Expected	Got
[ { replacetest1@v1.2.3 golang.org/x/example@v0.0.0-20210811190340-787a929d5a0d } { replacetest2@v0.0.1 golang.org/x/example@v0.0.0-20210407023211-09c3a5e06b5d } { replacetest3@v1.2.3 \home\work\module\fork1 } { github.com/simnalamburt/module \home\work\module } { replacetest4@v0.0.1 \srv\fork2 } { replacetest5@v1.2.3 \home\work\module\fork3 } ]	[ { replacetest1@v1.2.3 golang.org/x/example@v0.0.0-20210811190340-787a929d5a0d } { replacetest2@v0.0.1 golang.org/x/example@v0.0.0-20210407023211-09c3a5e06b5d } { replacetest3@v1.2.3 \home\work\module\fork1 } { github.com/simnalamburt/module /home/work/module } { replacetest4@v0.0.1 \home\work\module\srv\fork2 } { replacetest5@v1.2.3 \home\work\module\fork3 } ]

[simnalamburt]

OK I think I fixed windows build, but now I failed Go 1.16 build due to the use of //go:build style build constraints.

[mohammed90]

OK I think I fixed windows build, but now I failed Go 1.16 build due to the use of //go:build style build constraints.

For this you have to use the older style // +build windows just below the newer style. Have them both in the same file just below each other.

[simnalamburt]

Note: I tried not to split main_unix_test.go and main_windows_test.go, but their JSON looks too different so it was really hard to generate two JSON in one test code.

[francislavoie]

If only Go supported the ternary condition operator 😂

[mohammed90]

This looks good! One minor nitpick then it's all right.

[simnalamburt]

I changed map[string]interface{} into Module and the CI has passed in my fork.

[mohammed90]

Had to handle one last minor nitpick. Perfecto. Thanks @simnalamburt!