Pin versions with go.mod, similar to server #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Groxx
commented
Feb 18, 2021
Comment on lines
-40
to
+39
| go.uber.org/atomic v1.5.1 | ||
| go.uber.org/atomic v1.4.0 |
There was a problem hiding this comment.
This downgrade is a bit odd. Possibly it's not imported locally + transitive dependencies changed and this is the new minimum?
It's very likely safe / good to upgrade to latest. Latest does make a breaking change though, disallowing comparison between atomic wrappers (which is a good thing, as that's racy behavior).
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 18, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 18, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 18, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 18, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Pull Request Test Coverage Report for Build 3cb9e29a-b43c-4d9f-8388-fd80127d350b
💛 - Coveralls |
|
Current deps output for comparison: This covers tools and libraries. |
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
github-actions bot
pushed a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time.
Groxx
added a commit
to cadence-workflow/cadence
that referenced
this pull request
Feb 19, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. An alternative option is to use something like https://github.com/psampaz/go-mod-outdated, but unfortunately that one will just tell you _what_ updates are available, not how old they are. It's pretty good otherwise though. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time. --- The output currently shows the maximum of these two values, as it feels like a pretty good "badness" metric: - how much time has passed between the current version and the latest version - how much time has passed since the latest version was released Either alone produces some non-great edge cases: - with only the first: - a long-stable library with a fix today looks 100s of days old - a release -> immediate bugfix release looks 0 days old (e.g. `rsc.io/sampler`) - with only the second: - a consistently-releasing library always looks "recent-ish". e.g. prior to them using tags, golang.org/x/tools would usually look <7 days old, as `master` is updated frequently... even though we were a few months behind. Ideally, IMO, this would check for both: - how old is our current version? (which this does) - how long have we ignored _any_ update? But AFAICT that'd require custom requests to a goproxy, as we cannot get "current+1" versions, only "current" and "latest".
just-at-uber
approved these changes
Feb 22, 2021
meiliang86
approved these changes
Feb 22, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
While building github.com/cadence-workflow/cadence-go-client/pull/1060, I realized I kinda missed the out-of-date warnings. So here's something kinda similar. An alternative option is to use something like https://github.com/psampaz/go-mod-outdated, but unfortunately that one will just tell you _what_ updates are available, not how old they are. It's pretty good otherwise though. It may be worth adding e.g. a "nothing > 100 days" check to `make lint` and/or CI? Otherwise I tend to see dependencies go un-upgraded for huge lengths of time. --- The output currently shows the maximum of these two values, as it feels like a pretty good "badness" metric: - how much time has passed between the current version and the latest version - how much time has passed since the latest version was released Either alone produces some non-great edge cases: - with only the first: - a long-stable library with a fix today looks 100s of days old - a release -> immediate bugfix release looks 0 days old (e.g. `rsc.io/sampler`) - with only the second: - a consistently-releasing library always looks "recent-ish". e.g. prior to them using tags, golang.org/x/tools would usually look <7 days old, as `master` is updated frequently... even though we were a few months behind. Ideally, IMO, this would check for both: - how old is our current version? (which this does) - how long have we ignored _any_ update? But AFAICT that'd require custom requests to a goproxy, as we cannot get "current+1" versions, only "current" and "latest".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioning strategy unfortunately is leaking some dependencies, and codegen isn't reproducible any more.
This update mimics how github.com/uber/cadence does dependencies, and is more "normal" for go modules anyway.
Implications of these changes include:
replacedirectives.And since this does away with the "X commits / versions behind current" notification: I've added
make deps(andmake deps-all), which works the same way as in cadence-workflow/cadence/pull/4000. Hopefully it's understandable enough to modify easily.