-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show loader skeleton in result view for running workflows #705
Merged
Assem-Uber
merged 6 commits into
cadence-workflow:release/4.0.0
from
adhityamamallan:running-wf-output
Oct 31, 2024
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
759b6e1
init commit for loading
adhityamamallan 049c1e6
Add loader
adhityamamallan 580969b
fix test
adhityamamallan 85be48e
Fix lint issue
adhityamamallan 94dfca9
Fix colours
adhityamamallan 3fd148a
update snapshots
adhityamamallan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
src/components/pretty-json-skeleton/pretty-json-skeleton.styles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { type Theme } from 'baseui'; | ||
import { type SkeletonOverrides } from 'baseui/skeleton/types'; | ||
import { type StyleObject } from 'styletron-react'; | ||
|
||
export const overrides = { | ||
borderSkeleton: { | ||
Row: { | ||
style: ({ $theme }: { $theme: Theme }): StyleObject => ({ | ||
height: $theme.sizing.scale600, | ||
borderRadius: $theme.borders.radius500, | ||
}), | ||
}, | ||
} satisfies SkeletonOverrides, | ||
centralSkeleton: { | ||
Root: { | ||
style: ({ $theme }: { $theme: Theme }): StyleObject => ({ | ||
marginLeft: $theme.sizing.scale550, | ||
marginTop: $theme.sizing.scale400, | ||
marginBottom: $theme.sizing.scale400, | ||
}), | ||
}, | ||
Row: { | ||
style: ({ $theme }: { $theme: Theme }): StyleObject => ({ | ||
height: $theme.sizing.scale600, | ||
borderRadius: $theme.borders.radius500, | ||
}), | ||
}, | ||
} satisfies SkeletonOverrides, | ||
}; |
30 changes: 30 additions & 0 deletions
30
src/components/pretty-json-skeleton/pretty-json-skeleton.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
'use client'; | ||
import { Skeleton } from 'baseui/skeleton'; | ||
|
||
import { overrides } from './pretty-json-skeleton.styles'; | ||
import { type Props } from './pretty-json-skeleton.types'; | ||
|
||
export default function PrettyJsonSkeleton({ width }: Props) { | ||
return ( | ||
<div> | ||
<Skeleton | ||
width="20px" | ||
rows={1} | ||
overrides={overrides.borderSkeleton} | ||
animation | ||
/> | ||
<Skeleton | ||
width={width} | ||
rows={3} | ||
overrides={overrides.centralSkeleton} | ||
animation | ||
/> | ||
<Skeleton | ||
width="20px" | ||
rows={1} | ||
overrides={overrides.borderSkeleton} | ||
animation | ||
/> | ||
</div> | ||
); | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/pretty-json-skeleton/pretty-json-skeleton.types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export type Props = { | ||
width: string; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please correct the tertiaryBackground color in the theme and use it. Keeping both web and design inconsistent would make moving forward much harder