-
Notifications
You must be signed in to change notification settings - Fork 805
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add pagination and flatten customized search attributes (#5234)
* implement pagination * add a test case for nextPageToken * add more test cases for pagination * change elastic search token into pinot token * clean up * fix count didn'w work issue * try to implement flatten schema, add attributes into schema * add attributes into schema * add some code to convert time to unix time in customized search attributes * refactor previously added code to a function * customized search attributes and unit tests * Remove attr column and minor clean up * edge case for ORDER BY in customized search attribute * Fix typo in name * add one more condition for parseLastElement * split one element of customized search attribute by operator instead of space; add a filter for customized attributes prefix * update unit test * update unit test --------- Co-authored-by: Neil Xie <neil.xie@uber.com>
- Loading branch information
Showing
8 changed files
with
915 additions
and
218 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Copyright (c) 2020 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package pinot | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| "github.com/uber/cadence/common/types" | ||
| ) | ||
|
|
||
| type ( | ||
| // PinotVisibilityPageToken holds the paging token for Pinot | ||
| PinotVisibilityPageToken struct { | ||
| From int | ||
| } | ||
| ) | ||
|
|
||
| // DeserializePageToken return the structural token | ||
| func DeserializePageToken(data []byte) (*PinotVisibilityPageToken, error) { | ||
| var token PinotVisibilityPageToken | ||
| dec := json.NewDecoder(bytes.NewReader(data)) | ||
| dec.UseNumber() | ||
| err := dec.Decode(&token) | ||
| if err != nil { | ||
| return nil, &types.BadRequestError{ | ||
| Message: fmt.Sprintf("unable to deserialize page token. err: %v", err), | ||
| } | ||
| } | ||
| return &token, nil | ||
| } | ||
|
|
||
| // SerializePageToken return the token blob | ||
| func SerializePageToken(token *PinotVisibilityPageToken) ([]byte, error) { | ||
| data, err := json.Marshal(token) | ||
| if err != nil { | ||
| return nil, &types.BadRequestError{ | ||
| Message: fmt.Sprintf("unable to serialize page token. err: %v", err), | ||
| } | ||
| } | ||
| return data, nil | ||
| } | ||
|
|
||
| // GetNextPageToken returns the structural token with nil handling | ||
| func GetNextPageToken(token []byte) (*PinotVisibilityPageToken, error) { | ||
| var result *PinotVisibilityPageToken | ||
| var err error | ||
| if len(token) > 0 { | ||
| result, err = DeserializePageToken(token) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } else { | ||
| result = &PinotVisibilityPageToken{} | ||
| } | ||
| return result, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,4 +42,5 @@ | |
| "indexTypes":["TEXT"] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters