fix comments

cadence-workflow · Mar 27, 2018 · ba98a3b · ba98a3b
1 parent a900c2c
commit ba98a3b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/service/history/historyTestBase.go b/service/history/historyTestBase.go
@@ -138,13 +138,14 @@ func (s *TestShardContext) GetTransferAckLevel() int64 {
 	s.RLock()
 	defer s.RUnlock()
 
-	// TODO change make this cluster input parameter
+	// TODO cluster should be an input parameter
 	cluster := s.GetService().GetClusterMetadata().GetCurrentClusterName()
-	// if can find corresponding ack level in the cluster to timer ack level map
+	// if we can find corresponding ack level
 	if ackLevel, ok := s.shardInfo.ClusterTransferAckLevel[cluster]; ok {
 		return ackLevel
 	}
 	// otherwise, default to existing ack level, which belongs to local cluster
+	// this can happen if you add more cluster
 	return s.shardInfo.TransferAckLevel
 }
 
@@ -153,7 +154,7 @@ func (s *TestShardContext) UpdateTransferAckLevel(ackLevel int64) error {
 	s.RLock()
 	defer s.RUnlock()
 
-	// TODO change make this cluster input parameter
+	// TODO cluster should be an input parameter
 	cluster := s.GetService().GetClusterMetadata().GetCurrentClusterName()
 	if cluster == s.GetService().GetClusterMetadata().GetCurrentClusterName() {
 		s.shardInfo.TransferAckLevel = ackLevel
@@ -172,11 +173,12 @@ func (s *TestShardContext) GetTimerAckLevel(cluster string) time.Time {
 	s.RLock()
 	defer s.RUnlock()
 
-	// if can find corresponding ack level in the cluster to timer ack level map
+	// if we can find corresponding ack level
 	if ackLevel, ok := s.shardInfo.ClusterTimerAckLevel[cluster]; ok {
 		return ackLevel
 	}
 	// otherwise, default to existing ack level, which belongs to local cluster
+	// this can happen if you add more cluster
 	return s.shardInfo.TimerAckLevel
 }
 

diff --git a/service/history/shardContext.go b/service/history/shardContext.go
@@ -121,13 +121,14 @@ func (s *shardContextImpl) GetTransferAckLevel() int64 {
 	s.RLock()
 	defer s.RUnlock()
 
-	// TODO change make this cluster input parameter
+	// TODO cluster should be an input parameter
 	cluster := s.GetService().GetClusterMetadata().GetCurrentClusterName()
-	// if can find corresponding ack level in the cluster to timer ack level map
+	// if we can find corresponding ack level
 	if ackLevel, ok := s.shardInfo.ClusterTransferAckLevel[cluster]; ok {
 		return ackLevel
 	}
 	// otherwise, default to existing ack level, which belongs to local cluster
+	// this can happen if you add more cluster
 	return s.shardInfo.TransferAckLevel
 }
 
@@ -141,7 +142,7 @@ func (s *shardContextImpl) UpdateTransferAckLevel(ackLevel int64) error {
 	s.Lock()
 	defer s.Unlock()
 
-	// TODO change make this cluster input parameter
+	// TODO cluster should be an input parameter
 	cluster := s.GetService().GetClusterMetadata().GetCurrentClusterName()
 	if cluster == s.GetService().GetClusterMetadata().GetCurrentClusterName() {
 		s.shardInfo.TransferAckLevel = ackLevel
@@ -155,11 +156,12 @@ func (s *shardContextImpl) GetTimerAckLevel(cluster string) time.Time {
 	s.RLock()
 	defer s.RUnlock()
 
-	// if can find corresponding ack level in the cluster to timer ack level map
+	// if we can find corresponding ack level
 	if ackLevel, ok := s.shardInfo.ClusterTimerAckLevel[cluster]; ok {
 		return ackLevel
 	}
 	// otherwise, default to existing ack level, which belongs to local cluster
+	// this can happen if you add more cluster
 	return s.shardInfo.TimerAckLevel
 }