Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(paused, may cancel) Rename .gen -> gen for go 1.16 compatibility #3987

Closed
wants to merge 1 commit into from

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Feb 17, 2021

Hopefully resolves #3980 , when complete.
In a nutshell: go hasn't liked .gen since some time in 2018, but 1.16 was just released and now it's enforced.
Doing anything with 1.16 with modules enabled produces errors like:

go.uber.org/cadence/workflow imports
go.uber.org/cadence/.gen/go/shared: malformed import path "go.uber.org/cadence/.gen/go/shared": leading dot in path element

So this commit:

  • changes the generated source dirs from ".gen" to "gen"
  • changes licensegen to look at the new path
  • moves the old proto files from .gen into gen
  • find-and-replaces all github.com/uber/cadence/{.gen,gen}
  • to test: clean and rebuild proto + thrift to make sure it's stable (it is)

To be complete, we'll need to make a new release of go.uber.org/cadence with similar changes, and import it here.
Unfortunately that PR is a fair bit more complex, so I'll wait for that to be decided before continuing here: cadence-workflow/cadence-go-client/pull/1057

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 64.623% when pulling ec5c7b5 on sixteen into 59a98cf on master.

@Groxx Groxx changed the title Rename .gen -> gen for go 1.16 compatibility (paused, may cancel) Rename .gen -> gen for go 1.16 compatibility Mar 6, 2021
@Groxx
Copy link
Member Author

Groxx commented Jul 6, 2022

no longer necessary, Go un-broke this.

@Groxx Groxx closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gen: rename subdirectory for 1.16 compatibility
2 participants