Switch to gogo and yarpc compilers #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytautas-karpavicius
force-pushed
the
protoc-gogo-yarpc
branch
from
5c94430
to
a449c3a
Compare
vytautas-karpavicius
force-pushed
the
protoc-gogo-yarpc
branch
5 times, most recently
from
1b04c03
to
5aed510
Compare
vytautas-karpavicius
force-pushed
the
protoc-gogo-yarpc
branch
from
ed7ca3e
to
1891c96
Compare
andrewjdawson2016
approved these changes
Mar 13, 2021
vytautas-karpavicius
added a commit
that referenced
this pull request
Mar 15, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that previous switch to use google/protobuf 1.4.x (v2) compiler was made too soon. This is due to the fact, that in Cadence we use YARPC framework which is still on gogo. Messages in gogo are not compatible with 1.4.x protobuf library and causes panics during serialization. YARPC is in the process of migrating off gogo. But as I was told it is at least several months away.
In order for GRPC migration to move forward, we will switch back to gogo. However this is not a pure revert of previous PR. We still want to get rid of all gogo extensions. Having them will make future switch to protobuf 1.4.x more difficult.
To generate YARPC server and client code
protoc-gen-yarpc-goplugin is used. Currently used version does not support alias ingo_packageoption however. A fix was made for it. Since it is not released yet, I have added a temporaryreplacein go.mod for it. Anotherreplaceis necessary for apache/thrift. Updatedyarpcmodule brings new version of apache/thrift with breaking changes. Howevertchannel-goandringpop-gostill uses older one.