Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building in command line places build folder outside of repo #24

Open
grebz-dev opened this issue Oct 28, 2022 · 0 comments
Open

Building in command line places build folder outside of repo #24

grebz-dev opened this issue Oct 28, 2022 · 0 comments
Labels
bug light A bug that isn't a priority build Issues relating to the build process needs repro Needs additional reproducible examples

Comments

@grebz-dev
Copy link

Describe the bug
Building from the command line produces warnings. Build completes successfully but places build folder in unexpected directory.

To Reproduce
Follow build instructions for Python Release

Expected behavior
No warnings are expected
Build folder is expected at dhart/build/Python/

Screenshots
The following output is produced by the first step:

-- Selecting Windows SDK version 10.0.20348.0 to target Windows 10.0.19044.
cmake : CMake Warning:
At line:1 char:1
+ cmake ./src/  -G"Visual Studio 16 2019"  -DCMAKE_GENERATOR_PLATFORM=" ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (CMake Warning::String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
  Ignoring extra path from command line:
   ".\"
-- The C compiler identification is MSVC 19.29.30146.0
-- The CXX compiler identification is MSVC 19.29.30146.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
 EIGEN DIR 
 ROBIN_HOOD 
[STATUS]All Selected as the current DHARTAPI_Configuration
[STATUS]Generating all packages
[STATUS]Setting embree dir to C:/Users/USER/Documents/GitHub/dhart/src/external/Embree
Installing Python!
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:
    INSTALL_GTEST
-- Build files have been written to: C:/Users/USER/Documents/GitHub/dhart

Build and install complete successfully.

Build folder appears in the parent directory.

Additional context

Some of the Visual Studio tools required in BUILD.md are not listed in the Visual Studio Community 2019 Installer by name. As many as could be found + anything related was used.

@cadop cadop added bug Something isn't working bug light A bug that isn't a priority build Issues relating to the build process needs repro Needs additional reproducible examples and removed bug Something isn't working labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug light A bug that isn't a priority build Issues relating to the build process needs repro Needs additional reproducible examples
Projects
None yet
Development

No branches or pull requests

2 participants