Skip to content

Commit

Permalink
Merge branch 'hotfix/0.6.4' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
gep13 committed Dec 9, 2015
2 parents 21b8247 + 54b48ba commit 8bb5f80
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
3 changes: 3 additions & 0 deletions ReleaseNotes.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### New in 0.6.4 (Released 2015/12/09)
* Quoted process fails on unix

### New in 0.6.3 (Released 2015/12/07)
* ProcessStartInfo filename not always Quoted
* Support spaces in MSBuild configuration
Expand Down
7 changes: 5 additions & 2 deletions src/Cake.Core/IO/ProcessRunner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,16 @@ public IProcess Start(FilePath filePath, ProcessSettings settings)
throw new ArgumentNullException("settings");
}

// Get the fileName
var fileName = _environment.IsUnix() ? filePath.FullPath : filePath.FullPath.Quote();

// Get the arguments.
var arguments = settings.Arguments ?? new ProcessArgumentBuilder();

if (!settings.Silent)
{
// Log the filename and arguments.
var message = string.Concat(filePath, " ", arguments.RenderSafe().TrimEnd());
var message = string.Concat(fileName, " ", arguments.RenderSafe().TrimEnd());
_log.Verbose(Verbosity.Diagnostic, "Executing: {0}", message);
}

Expand All @@ -63,7 +66,7 @@ public IProcess Start(FilePath filePath, ProcessSettings settings)
settings.WorkingDirectory = workingDirectory.MakeAbsolute(_environment);

// Create the process start info.
var info = new ProcessStartInfo(filePath.FullPath.Quote())
var info = new ProcessStartInfo(fileName)
{
Arguments = arguments.Render(),
WorkingDirectory = workingDirectory.FullPath,
Expand Down
6 changes: 3 additions & 3 deletions src/SolutionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
using System.Reflection;

[assembly: AssemblyProduct("Cake")]
[assembly: AssemblyVersion("0.6.3")]
[assembly: AssemblyFileVersion("0.6.3")]
[assembly: AssemblyInformationalVersion("0.6.3")]
[assembly: AssemblyVersion("0.6.4")]
[assembly: AssemblyFileVersion("0.6.4")]
[assembly: AssemblyInformationalVersion("0.6.4")]
[assembly: AssemblyCopyright("Copyright (c) Patrik Svensson, Mattias Karlsson, Gary Ewan Park and contributors")]

2 changes: 1 addition & 1 deletion tools/packages.config
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Cake" version="0.6.2" />
<package id="Cake" version="0.6.3" />
<package id="xunit.runner.console" version="2.0.0" />
<package id="gitreleasemanager" version="0.3.0" />
</packages>

0 comments on commit 8bb5f80

Please sign in to comment.