Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolSettings should allow should support of exit codes other than 0 #1023

Closed
Sam13 opened this issue Jun 29, 2016 · 1 comment
Closed

ToolSettings should allow should support of exit codes other than 0 #1023

Sam13 opened this issue Jun 29, 2016 · 1 comment
Labels
Milestone

Comments

@Sam13
Copy link
Contributor

Sam13 commented Jun 29, 2016

Currently a CakeException is thrown when a tool has other exit code than zero.

Since they are tools around (e.g. RoboCopy) which have different exit codes I suggest to add a list of valid exit codes to the ToolSettings class.

Or add a custom validation callback (Func<int, bool>) to validate the exit code on client side (similar to postAction) of Tool.Run()

@devlead devlead added this to the v0.14.0 milestone Jul 7, 2016
@devlead
Copy link
Member

devlead commented Jul 7, 2016

Fixed by #1031

@devlead devlead closed this as completed Jul 7, 2016
@gep13 gep13 added the Feature label Jul 10, 2016
@gep13 gep13 changed the title Tool should support other exit codes than 0 ToolSettings should allow should support of exit codes other than 0 Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants