Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include & exlude parameters to #tool directive #1184

Closed
devlead opened this issue Aug 24, 2016 · 2 comments
Closed

Add include & exlude parameters to #tool directive #1184

devlead opened this issue Aug 24, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@devlead
Copy link
Member

devlead commented Aug 24, 2016

Currently #tool directive exclusively looks for *.exe, this locks out a few scenarios including CoreCLR as command line assemblies there have dll extension.

Proposed fix for this is to add 2 new optional parameters to the #tool directive that lets you specify your own globbing pattern to override the default behavior.

parameter description example
include pattern of which files to look for #tool nuget:?package=Cake.Foo&include=./**/Foo.dll
exclude pattern of which files not considered tools #tool nuget:?package=Cake.Foo&exclude=./**/*Serializer*.dll

You should also be able to specify multiple globbing patterns i.e.
#tool nuget:?package=Cake.Foo&include=./**/*.dll&include=./**/*.exe&exclude=./**/*Serializer*.dll&exclude=./**/Foo.dll

@devlead devlead added this to the v0.16.0 milestone Aug 24, 2016
@patriksvensson
Copy link
Member

@gep13 @devlead Anyone started with this yet or can I implement this?

@devlead
Copy link
Member Author

devlead commented Aug 29, 2016

@patriksvensson no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants