Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquoted VSTest settings file path #1271

Closed
jnm2 opened this issue Oct 11, 2016 · 1 comment
Closed

Unquoted VSTest settings file path #1271

jnm2 opened this issue Oct 11, 2016 · 1 comment
Labels
Milestone

Comments

@jnm2
Copy link
Contributor

jnm2 commented Oct 11, 2016

I wanted to add a different path VSTest argument and I looked at SettingsFile as a pattern to copy, but I found some issues with its current implementation.
The SettingsFile argument is not quoted. Filenames that contain spaces will cause problems. I've confirmed the expected behavior at the command line.

@gep13 pointed out AppendSwitchQuoted which is more idiomatic than the string.Format that was previously used in this method, so I changed all the switches to use AppendSwitch or AppendSwitchQuoted and that resolved the issue.

Fix is here: #1268

@gep13
Copy link
Member

gep13 commented Oct 11, 2016

Thanks for noticing and fixing this. It will be released in 0.17.0 of Cake.

@gep13 gep13 closed this as completed Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants