Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup/Teardown should provide ICakeContext #743

Closed
patriksvensson opened this issue Mar 8, 2016 · 9 comments
Closed

Setup/Teardown should provide ICakeContext #743

patriksvensson opened this issue Mar 8, 2016 · 9 comments
Assignees
@patriksvensson
Labels
Improvement
Milestone
v0.11.0

Comments

@patriksvensson
Copy link
Member

The Setup/Teardown methods on the ScriptHost does not provide a ICakeContext for the delegate. Of course we will still have to support the old way, but would like those method to be a Action<ICakeContext> instead of a parameterless Action.
@gep13
Copy link
Member

gep13 commented Mar 9, 2016

@patriksvensson this would allow the overall assertion of whether a build succeeded or not in the Teardown method, right?

@devlead
Copy link
Member

devlead commented Mar 9, 2016

@gep13 would be nice if one in the tear down could get a hold of last exception / errror

@patriksvensson
Copy link
Member Author

@gep13 @devlead Yes, Maybe we should provide a ISetupContext and a ITeardownContext just as we do with task setup/teardown.

@gep13
Copy link
Member

gep13 commented Mar 9, 2016

@devlead @patriksvensson 👍

@devlead
Copy link
Member

devlead commented Mar 9, 2016

@patriksvensson @gep13 👍

@gep13
Copy link
Member

gep13 commented Mar 10, 2016

@patriksvensson is this issue a duplicate of this one: #686

@patriksvensson
Copy link
Member Author

@gep13 Yes. Kind of 😄

@gep13
Copy link
Member

gep13 commented Mar 10, 2016

Should we close the other one, and leave only this one?

@patriksvensson
Copy link
Member Author

@gep13 Yes. I'll do that.

@patriksvensson patriksvensson mentioned this issue Mar 10, 2016
Closed
@gep13 gep13 mentioned this issue Mar 10, 2016
Closed
@patriksvensson patriksvensson self-assigned this Apr 11, 2016
@patriksvensson patriksvensson mentioned this issue Apr 11, 2016
Merged
@gep13 gep13 added this to the v0.11.0 milestone Apr 15, 2016
ChrisMaddock pushed a commit to ChrisMaddock/cake that referenced this issue May 5, 2016
@patriksvensson @ChrisMaddock
Provided ICakeContext to Setup/Teardown.
425456b 
Also obsoleted (with warning) old methods that don't use the
ICakeContext version of the methods.

Closes cake-build#743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patriksvensson patriksvensson

Labels
Improvement
Projects
None yet
Milestone
v0.11.0
Development

No branches or pull requests
3 participants
@patriksvensson @gep13 @devlead