Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic optional tool timeout #830

Closed
devlead opened this issue Apr 18, 2016 · 6 comments
Closed

Add generic optional tool timeout #830

devlead opened this issue Apr 18, 2016 · 6 comments
Assignees
Milestone

Comments

@devlead
Copy link
Member

devlead commented Apr 18, 2016

Currently some tools can hang with no chance of recovery, the ability to optionally set a timeout for would allow to take action in script and do retry or just abort on timeout.

@devlead devlead self-assigned this Apr 18, 2016
devlead added a commit to devlead/cake that referenced this issue Apr 18, 2016
devlead added a commit to devlead/cake that referenced this issue Apr 18, 2016
@daveaglick
Copy link
Member

Is the timeout opt-in or opt-out (I.e., will there be a default timeout for tools that don't specify an alternative)?

@devlead
Copy link
Member Author

devlead commented Apr 18, 2016

@daveaglick it's opt-in.

@devlead
Copy link
Member Author

devlead commented Apr 18, 2016

@daveaglick didn't wanna change any semantics in #831, could be a bigger discussion later if we should change default behavior or not.

@daveaglick
Copy link
Member

👍 Cool, this is a good addition. Doesn't really make a difference one way or the other, just wanted to be sure I'm following the correct semantics since I've got some fairly long-running processes.

@devlead
Copy link
Member Author

devlead commented Apr 18, 2016

@daveaglick personally it will solve many mono issues where tools in sometimes takes 2 tries to work, i.e. nuget restore which is safe to run again 😉

devlead added a commit to devlead/cake that referenced this issue Apr 18, 2016
devlead added a commit to devlead/cake that referenced this issue Apr 18, 2016
devlead added a commit to devlead/cake that referenced this issue Apr 18, 2016
@patriksvensson patriksvensson added this to the v0.11.0 milestone Apr 18, 2016
@patriksvensson
Copy link
Member

Closed via #831.

ChrisMaddock pushed a commit to ChrisMaddock/cake that referenced this issue May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants