Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress obsolete warnings on Mono #974

Closed
patriksvensson opened this issue Jun 8, 2016 · 4 comments · Fixed by #1012
Closed

Suppress obsolete warnings on Mono #974

patriksvensson opened this issue Jun 8, 2016 · 4 comments · Fixed by #1012
Milestone

Comments

@patriksvensson
Copy link
Member

Mono seems to care about obsoleted aliases even though they only exist in generated code and isn't explicitly called. We could work around this by creating a custom attribute for aliases like CakeObsoletedAliasAttribute.

image

@patriksvensson patriksvensson added this to the v0.14.0 milestone Jun 8, 2016
@devlead
Copy link
Member

devlead commented Jun 8, 2016

Could also be that we should ignore on the generated classes.

Also on that note, we should probably now remove the obsolete XmlPoke methods.

@patriksvensson
Copy link
Member Author

@devlead We call the obsoleted methods in the generated aliases. I think that is the problem.
Yes, we should remove the XmlPoke methods.

We should also invest in a way of tracking stuff that we obsolete. Like when we obsoleted it (what version).

@devlead
Copy link
Member

devlead commented Jun 9, 2016

a warning version and error version options to attribute perhaps.

@patriksvensson
Copy link
Member Author

@devlead Not a bad idea. Let me think some more about this.

devlead added a commit to devlead/cake that referenced this issue Jun 27, 2016
devlead added a commit to devlead/cake that referenced this issue Jun 28, 2016
gep13 added a commit that referenced this issue Jun 28, 2016
GH974: Supress obsolete warnings from generated code
@patriksvensson patriksvensson changed the title Add custom attribute for obsoleted aliases Suppress obsolete warnings on Mono Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants