Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the grammar "do/does" in exception messages and tests #1263

Merged

Conversation

stevensona
Copy link
Contributor

@stevensona stevensona commented Oct 8, 2016

Hey guys,
I was turned onto the project by the Hanselminutes podcast. I dove right in and noticed that the exception messages had a grammar error. So I updated the messages and associated tests to reflect the change.

@dnfclas
Copy link

dnfclas commented Oct 8, 2016

Hi @stevensona, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Oct 8, 2016

@stevensona, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 added this to the v0.17.0 milestone Oct 9, 2016
@gep13
Copy link
Member

gep13 commented Oct 9, 2016

@stevensona thank you very much for taking the time to make these corrections, it is much appreciated!

@gep13 gep13 merged commit 96e0817 into cake-build:develop Oct 9, 2016
@gep13
Copy link
Member

gep13 commented Oct 9, 2016

@stevensona said...
I was turned onto the project by the Hanselminutes podcast. I dove right in

Glad to hear that you liked the show! We were very grateful to @shanselman for having @patriksvensson on. Let us know if you have any questions about getting started with Cake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants