-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH1422: Add support for Unicode globbing #1611
Conversation
@tom-dudley, It will cover your contributions to all .NET Foundation-managed open source projects. |
@tom-dudley, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
a8dcfee
to
89c4567
Compare
If the OS X bitrise error is genuine (I read elsewhere you might be having issues with bitrise), could you make the output publicly viewable or let me know what the failure was? Thanks! |
@tom-dudley I took a look at it and it doesn't seem to be related to your changes. |
@tom-dudley @patriksvensson reran the Bitrise Mac Build and it completed successfuly |
@tom-dudley Thanks for taking this issue up! |
89c4567
to
6d3ff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@tom-dudley your changes have been merged, thanks for your contribution 👍 |
I've added Unicode support to the Globber by rewriting the
GlobTokenizer
. This fixes #1422GlobTokenizer
now specifies 'non-identifier characters' rather than 'identifier characters'