Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1422: Add support for Unicode globbing #1611

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

tom-dudley
Copy link

I've added Unicode support to the Globber by rewriting the GlobTokenizer. This fixes #1422

  • Tokens are lazily loaded into a queue
  • GlobTokenizer now specifies 'non-identifier characters' rather than 'identifier characters'
  • Globbing is 15% faster
  • Unicode supported

@dnfclas
Copy link

dnfclas commented May 17, 2017

@tom-dudley,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented May 17, 2017

@tom-dudley, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@tom-dudley tom-dudley force-pushed the unicode-globbing-vs2015 branch 3 times, most recently from a8dcfee to 89c4567 Compare May 17, 2017 23:49
@tom-dudley tom-dudley changed the title Add support for Unicode globbing GH1422: Add support for Unicode globbing May 17, 2017
@tom-dudley
Copy link
Author

If the OS X bitrise error is genuine (I read elsewhere you might be having issues with bitrise), could you make the output publicly viewable or let me know what the failure was? Thanks!

@patriksvensson
Copy link
Member

@tom-dudley I took a look at it and it doesn't seem to be related to your changes.

@devlead
Copy link
Member

devlead commented May 18, 2017

@tom-dudley @patriksvensson reran the Bitrise Mac Build and it completed successfuly

@SIkebe
Copy link
Contributor

SIkebe commented May 18, 2017

@tom-dudley Thanks for taking this issue up!

@devlead devlead force-pushed the unicode-globbing-vs2015 branch from 89c4567 to 6d3ff75 Compare August 3, 2017 06:58
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 6d3ff75 into cake-build:develop Aug 3, 2017
@devlead
Copy link
Member

devlead commented Aug 3, 2017

@tom-dudley your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Unkown token when directory contains multibyte characters
5 participants