Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH1693: Fix key not used when setting process environment variable #1717

Merged
merged 1 commit into from
Aug 2, 2017
Merged

GH1693: Fix key not used when setting process environment variable #1717

merged 1 commit into from
Aug 2, 2017
+1 −1

Conversation

devlead
Copy link
Member

@devlead devlead commented Aug 2, 2017

gep13
gep13 approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Aug 2, 2017

@devlead will merge once CI's finish.

@gep13 gep13 merged commit 93ca222 into cake-build:develop Aug 2, 2017
@gep13
Copy link
Member

gep13 commented Aug 2, 2017

@devlead your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible bug when setting process environment variable
3 participants
@devlead @gep13 @dnfclas